do not override already set content-type, fixes #1120 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 5 5
Lines 372 372
=======================================
Hits 371 371
Misses 1 1
Continue to review full report at Codecov.
|
jonathanong
approved these changes
Feb 6, 2018
|
this might break apps if someone is relying on this behavior, so i would wait for semver major. |
|
unless we only set it to json if the type is not json-like |
|
I agree @fl0w |
|
Any news about this PR? @jonathanong |
3imed-jaberi
approved these changes
Jan 11, 2021
|
Hi, it's been two years, any update on this PR? |
jonathanong
reviewed
Aug 31, 2024
| const res = response(); | ||
|
|
||
| res.body = '<em>hey</em>'; | ||
| assert.equal('text/html; charset=utf-8', res.header['content-type']); | ||
|
|
||
| res.body = { foo: 'bar' }; | ||
| assert.equal('application/json; charset=utf-8', res.header['content-type']); | ||
| assert.equal('text/html; charset=utf-8', res.header['content-type']); |
There was a problem hiding this comment.
this test case is already updated, so this feature must already be live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semver major, #1114
This could be done as semver minor - if an application setting is addd, e.g.
app.responsOverride = trueor something.