Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add writeCookie option in README #45

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

monkindey
Copy link
Contributor

No description provided.

@@ -48,6 +48,7 @@ Patch locales functions to koa app.
- {String} cookieField: locale field name on cookie. Optional, default is `locale`.
- {String} cookieDomain: domain on cookie. Optional, default is `''`.
- {Object} localeAlias: locale value map. Optional, default is `{}`.
- {Boolean} writeCookie: set cookie if header not sent. Optional, default is `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
just this update beacause i do the same here #43

Suggested change
- {Boolean} writeCookie: set cookie if header not sent. Optional, default is `true`.
- {Boolean} **writeCookie**: set cookie if header not sent. Optional, default is `true`.

@fengmk2 fengmk2 merged commit b22bfc5 into koajs:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants