Support setting cookie domain on a per-request basis.

koajs · Apr 23, 2024 · 44505f9 · 44505f9
1 parent 98630aa
commit 44505f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/context.js b/lib/context.js
@@ -128,7 +128,7 @@ class ContextSession {
       debug('decode %j error: %s', cookie, err);
       if (!(err instanceof SyntaxError)) {
         // clean this cookie to ensure next request won't throw again
-        ctx.cookies.set(opts.key, '', opts);
+        ctx.cookies.set(opts.key, '', util.modifyOptsForRequest(ctx, opts));
         // ctx.onerror will unset all headers, and set those specified in err
         err.headers = {
           'set-cookie': ctx.response.get('set-cookie'),
@@ -287,7 +287,7 @@ class ContextSession {
     const externalKey = this.externalKey;
 
     if (externalKey) await this.store.destroy(externalKey, { ctx });
-    ctx.cookies.set(key, '', opts);
+    ctx.cookies.set(key, '', util.modifyOptsForRequest(ctx, opts));
   }
 
   /**
@@ -328,7 +328,7 @@ class ContextSession {
       if (opts.externalKey) {
         opts.externalKey.set(this.ctx, externalKey);
       } else {
-        this.ctx.cookies.set(key, externalKey, opts);
+        this.ctx.cookies.set(key, externalKey, util.modifyOptsForRequest(this.ctx, opts));
       }
       return;
     }
@@ -338,7 +338,7 @@ class ContextSession {
     json = opts.encode(json);
     debug('save %s', json);
 
-    this.ctx.cookies.set(key, json, opts);
+    this.ctx.cookies.set(key, json, util.modifyOptsForRequest(this.ctx, opts));
   }
 }
 

diff --git a/lib/util.js b/lib/util.js
@@ -35,5 +35,13 @@ module.exports = {
     return crc(JSON.stringify(sess));
   },
 
+  modifyOptsForRequest(ctx, opts) {
+    const optsCopy = Object.assign({}, opts);
+    if (typeof opts.domain === "function") {
+      optsCopy.domain = opts.domain(ctx, opts);
+    }
+    return optsCopy;
+  },
+
   CookieDateEpoch: 'Thu, 01 Jan 1970 00:00:00 GMT',
 };