Merge pull request #5 from suitedjimster/logonmount_dependencies

Fix for LogOnChange and LogOnMount dependencies
koblas · May 11, 2020 · 5103b1d · 5103b1d
2 parents a016851 + cdfea57
commit 5103b1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/LogOnChange.tsx b/src/components/LogOnChange.tsx
@@ -11,11 +11,11 @@ type Props = {
 };
 
 export const LogOnChange: React.StatelessComponent<Props> = (props: Props) => {
-  const { logEvent, amplitudeInstance } = useAmplitude(undefined, props.instanceName);
+  const { logEvent } = useAmplitude(undefined, props.instanceName);
 
   React.useEffect(() => {
     logEvent(props.eventType, props.eventProperties);
-  }, [props.eventType, props.eventProperties, props.value, amplitudeInstance]);
+  }, [props.value]);
 
   return props.children || (null as any);
 };
@@ -25,5 +25,5 @@ LogOnChange.propTypes = {
   eventProperties: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
   eventType: PropTypes.string.isRequired,
   instanceName: PropTypes.string,
-  value: PropTypes.any
+  value: PropTypes.any,
 };
diff --git a/src/components/LogOnMount.tsx b/src/components/LogOnMount.tsx
@@ -10,17 +10,17 @@ type Props = {
 };
 
 export const LogOnMount: React.StatelessComponent<Props> = (props: Props) => {
-  const { logEvent, amplitudeInstance } = useAmplitude(undefined, props.instanceName);
+  const { logEvent } = useAmplitude(undefined, props.instanceName);
 
   React.useEffect(() => {
     logEvent(props.eventType, props.eventProperties);
-  }, [props.eventType, props.eventProperties, amplitudeInstance]);
+  }, []);
 
   return props.children || (null as any);
 };
 
 LogOnMount.propTypes = {
   eventProperties: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
   eventType: PropTypes.string.isRequired,
-  instanceName: PropTypes.string
+  instanceName: PropTypes.string,
 };