Merge pull request #59 from koblas/cleanup

fix: small cleanups, github testing
koblas · Jun 25, 2023 · 6d0ecb4 · 6d0ecb4
2 parents 12eb64d + b5929b5
commit 6d0ecb4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -53,7 +53,7 @@ jobs:
       run: echo "version=$(npx semantic-release --version)" >> "$GITHUB_OUTPUT"
     - name: GitHub Release update
       uses: softprops/action-gh-release@v1
-      if: startsWith(github.ref, 'refs/tags/')
+      #if: startsWith(github.ref, 'refs/tags/')
       with:
         # body_path: ${{ github.workspace }}-CHANGELOG.txt
         # note you'll typically need to create a personal access token

diff --git a/src/nl/bsn.spec.ts b/src/nl/bsn.spec.ts
@@ -8,6 +8,15 @@ describe('nl/bsn', () => {
     expect(result).toEqual('1112.22.333');
   });
 
+  test.each([
+    '001855013', // RSIN
+    '1112.22.333', // BSN
+  ])('isValid', value => {
+    const result = validate(value);
+
+    expect(result.isValid).toEqual(true);
+  });
+
   it('validate:1112.22.333', () => {
     const result = validate('1112.22.333');
 

diff --git a/src/nl/btw.ts b/src/nl/btw.ts
@@ -75,7 +75,7 @@ const impl: Validator = {
 
     const sum = weightedSum(a, {
       weights: [9, 8, 7, 6, 5, 4, 3, 2, -1],
-      modulus: 10000,
+      modulus: 11,
     });
 
     if (sum % 11 !== 0 && !mod97base10Validate(`NL${a}${b}${c}`)) {