Merge pull request #106 from koblas/no_fodselsnummer

fix: bug in year validation
koblas · Sep 6, 2023 · ce05f49 · ce05f49
2 parents 0ee6f7e + 731e9b1
commit ce05f49
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -3,7 +3,10 @@
   "version": "1.10.0",
   "description": "Standard Number Validation",
   "files": [
-    "lib"
+    "README.md",
+    "LICENSE.txt",
+    "lib",
+    "src"
   ],
   "main": "./lib/cjs/index.js",
   "module": "./lib/esm/index.js",

diff --git a/src/no/fodselsnummer.spec.ts b/src/no/fodselsnummer.spec.ts
@@ -8,14 +8,33 @@ describe('no/fodselsnummer', () => {
     expect(result).toEqual('151086 95088');
   });
 
-  test.each(['11111598403', '23114048690', '15108695088'])(
-    'validate:%s',
-    value => {
-      const result = validate(value);
-
-      expect(result.isValid).toEqual(true);
-    },
-  );
+  test.each([
+    '11111598403',
+    '23114048690',
+    '15108695088',
+    // from norsk-validator
+    '01010750160',
+    '30042099941',
+    '22052099424',
+    '09062099345',
+    '020161 26007',
+  ])('validate:%s', value => {
+    const result = validate(value);
+
+    expect(result.isValid).toEqual(true);
+  });
+
+  test.each([
+    '45014054018',
+    // from norsk-validator
+    '11111234567',
+    '1234123456',
+    '',
+  ])('validate:%s', value => {
+    const result = validate(value);
+
+    expect(result.isValid).toEqual(false);
+  });
 
   it('validate:151086 95088', () => {
     const result = validate('151086 95088');

diff --git a/src/no/fodselsnummer.ts b/src/no/fodselsnummer.ts
@@ -42,7 +42,7 @@ function checkBirthdate(value: string) {
     yy += 1800;
   } else if (rest < 1000 && yy < 40) {
     yy += 2000;
-  } else if (rest < 1000 && yy >= 40) {
+  } else if (rest >= 900 && rest < 1000 && yy >= 40) {
     yy += 1900;
   } else {
     return false;