fix: French VAT checksum failing for leading zero #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koblas
reviewed
Jun 4, 2024
| @@ -80,8 +80,7 @@ const impl: Validator = { | |||
| if (strings.isdigits(check)) { | |||
| const sum = (12 + 3 * (parseInt(back, 10) % 97)) % 97; | |||
|
|
|||
| const stringSum = String(sum).padStart(2, '0'); | |||
| if (stringSum !== check) { | |||
| if (sum !== parseInt(check, 10)) { | |||
There was a problem hiding this comment.
Would you mind adding a test case that handles this fix.
RamonBalthazar
force-pushed
the
fix-french-checksum-zero-pad
branch
from
1c5df67
to
ef5e5c1
Compare
|
@koblas Added test cases :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a valid French VAT number:
04813837531.The checksum bit is:
04.The sum is correctly being calculated as
4, but validation fails when comparing"4"with"04".As a solution we compare numbers instead of strings.