Feature: Remove attachments without deleting submissions #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_task-671_delete-button
…nt_task-671_delete-button
…nt_task-671_delete-button
…nt_task-671_delete-button
and add some TODO comments
magicznyleszek
force-pushed
the
feature/delete-attachment
branch
from
ad38cb7
to
0c32b6e
Compare
…nt_task-671_delete-button # Conflicts: # jsapp/js/components/submissions/submissionDataTable.tsx # jsapp/js/components/submissions/submissionModal.tsx
…nt_task-671_delete-button
…nt_task-671_delete-button
…nt_task-671_delete-button # Conflicts: # jsapp/js/components/formGallery/formGallery.component.tsx
…ask-671_delete-button [TASK-671] [TASK-558] Reusable delete attachment dropdown
# Conflicts: # jsapp/js/components/common/koboSelect.scss # jsapp/js/components/submissions/submissionModal.tsx
|
This PR is waiting for BE changes to be added. It has almost all FE changes needed for the feature to work (some mocking, some API calls missing). AFAIK we are delaying work on the feature until we build some other ones first |
# Conflicts: # jsapp/js/components/common/koboSelect.scss # jsapp/js/components/processing/sidebar/sidebarSubmissionMedia.module.scss # jsapp/js/components/submissions/submissionDataTable.tsx # jsapp/js/components/submissions/submissionModal.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a feature PR - it gathers reviewed and tested code in a single PR. We do smaller branches that are based in
feature/delete-attachmentbranch.Development Notes
Built atop these PRs (for easier work):
Zulip topic: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/Remove.20attachments.20without.20deleting.20submissions/near/441301