Code refactoring for project deployment #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs' into 4364-remove-invalid-default-values
noliveleger
changed the title
…-2-remove-imports
…django-app-part-2-openrosa-backend
This was referenced Jul 30, 2024
…_update_submissions"
…t-django-app-part-2-remove-kobocat-backend
- Remove logger.XForm `has_kpi_hook` field - Remove logger.Instance `posted_to_kpi` field - Remove openrosa.rest_service django app - Remove hook signal viewset
This was referenced Jul 31, 2024
…-condition Fix project transfer failure in some circumstances
# Conflicts: # kobo/apps/openrosa/apps/logger/models/attachment.py # kobo/apps/project_ownership/tests/api/v2/test_api.py # kpi/deployment_backends/kc_access/utils.py
…efactor-mock-deployment-backend Code refactoring: Simplify MockDeploymentBackend
…kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
…andle-missing-xform Code refactoring: Improve error message when XForm does not exist
…etter-error-handling Code refactoring: Better error handling in new deployment back-end class
…emove-service-account Code refactoring: Remove `kobo_service_account` dependency
# Conflicts: # kobo/apps/stripe/tests/test_organization_usage.py # kobo/apps/subsequences/tests/test_submission_stream.py # kpi/tests/api/v2/test_api_submissions.py # kpi/views/v2/data.py
7 tasks
…inter Linting Python code for deployment back-end class refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for devs interest only. It should simplify the way projects are deployed and how KPI interacts with KoboCAT.
Notes
Since KoboCAT is part of KPI code base in
openrosadjango app,KobocatDeploymentBackend, shadow models are not needed anymore. The goal of this PR is to regroup many other small PRs which make a part of refactoring (i.e. to avoid a big PR to review).OpenRosaDeploymentBackend(which calls directly Python code instead using a proxy to KoboCAT endpoints) (Code refactoring: Create new deployment backend class #5038)KobocatDeploymentBackend(Code refactoring - Remove shadow models and KobocatDeploymentBackend class #5042)kobo_service_accountdependency #5045)MockDeploymentBackendand fix unit tests (Code refactoring: Simplify MockDeploymentBackend #5056)Related issues