-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service usage cache and submissions suspended flag #5086
Open
Guitlle
wants to merge
33
commits into
billing-addons-backend
Choose a base branch
from
task-1005-cache-service-usage
base: billing-addons-backend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken tests
Signed-off-by: Guillermo <[email protected]> Signed-off-by: Guillermo <[email protected]>
…efactor-service-usage-serializer
Guitlle
force-pushed
the
task-1005-cache-service-usage
branch
from
August 30, 2024 22:59
d0e8990
to
274a788
Compare
Guitlle
changed the base branch from
beta-refactored
to
billing-addons-backend
August 31, 2024 16:04
Guitlle
force-pushed
the
task-1005-cache-service-usage
branch
from
September 3, 2024 14:27
af2e952
to
e25e1bf
Compare
…esponse for organizations
…nto task-1005-cache-service-usage
…for organizations API
noliveleger
requested changes
Sep 9, 2024
kobo/apps/openrosa/apps/logger/migrations/0029_populate_daily_xform_counters_for_year.py
Outdated
Show resolved
Hide resolved
noliveleger
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we could find a better PR title. It is not really obvious ;-)
Guitlle
changed the title
NLP Add ons
Service usage cache and submissions suspended flag
Sep 10, 2024
…or CachedClass class
…ations that should be pruned later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a reusable cache utility for classes to cache function getters. It is then used to cache the service usage calculator results. Some fields from the organization model are no longer needed due to this.
It also adds the submissions_suspended column to the user profile, instead of using the metadata JSON field.
Notes
The cached utility is at kpi.utils.cache, it is used by the ServiceUsageCalculator class. Note that for some tests, the cache has to be disabled, which can be done by patching the CachedClass methods. An example of this can be seen at
kpi/tests/api/v2/test_api_service_usage.py
Related issues
Fixes TASK-1005
Fixes TASK-1003
Part of TASK-872