[ TASK-1027 ] Conditional label for 'Delete Project and Data' button #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloamorimbr
changed the title
p2edwards
reviewed
Sep 11, 2024
| @@ -873,6 +873,10 @@ class ProjectSettings extends React.Component { | |||
| const isSelfOwned = assetUtils.isSelfOwned(this.state.formAsset); | |||
| const descriptionField = envStore.data.getProjectMetadataField('description'); | |||
|
|
|||
| const deleteButtonLabel = this.state.formAsset.deployment__submission_count > 0 ? | |||
There was a problem hiding this comment.
I wanted to check this real quick, since it's possible for deployment__submission_count to be null when viewed by users with row-level submission view permissions (see kpi#4739). But
thanks to the magic of JS, null > 0 is false, so no problem here, it's safe to run. Those users would lack 'manage this form' permission, so it's hard for them to get to this settings page anyway. 👍
There was a problem hiding this comment.
Thanks. I changed it in 5f22d64 and moved the condition to the element. Since it may not be rendered it does make more sense to leave the conditional label inside it as well. 🙇🏻
p2edwards
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK-1027
Checklist
Description
The "Delete Project" button label now can be either "Delete Project" and "Delete Project and Data" to reflect whether the project has submissions to be deleted along with the project or not.
Notes
This PR adds a conditional label for the 'Delete Project and Data' button, where it will only show 'Delete Project' when there's no submissions to the project.
No data:
With data:
I opted to isolate the label in a separated variable instead of adding the conditional logic into the button for better readability.Decided to go back in this decision and leave the condition in the element itself, since there are other conditions for the element rendering.