-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK-977] Switch account sidenav to style module #5118
Conversation
ddce81d
to
7e3bffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the icons and spacing are 1 or 2 pixels larger. Barely noticeable and I can't find where it's happening. I think it's fine though, no breaking changes.
Good catch. It was from a css rule I hadn't copied into the style module. Fixed now. |
Fix tiny issue introduced in #5118
Fix tiny issue introduced in #5118
Checklist
./python-format.sh
to make sure that your code lints and that you've followed our coding styleDescription
We will be updating the account sidenav for the organizations project and I am taking the opportunity to remove bem components here.
Testing
Compare account sidenav in this PR to its appearance on main. This PR shouldn't be making any visual changes.