Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-977] Switch account sidenav to style module #5118

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Sep 19, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section

Description

We will be updating the account sidenav for the organizations project and I am taking the opportunity to remove bem components here.

Testing

Compare account sidenav in this PR to its appearance on main. This PR shouldn't be making any visual changes.

Copy link

@jamesrkiger jamesrkiger marked this pull request as draft September 19, 2024 14:24
@jamesrkiger jamesrkiger marked this pull request as draft September 19, 2024 14:24
@jamesrkiger jamesrkiger force-pushed the task977-account-routing-and-sidenav branch from ddce81d to 7e3bffb Compare October 22, 2024 13:49
@jamesrkiger jamesrkiger changed the base branch from teams-project to main October 22, 2024 13:50
@jamesrkiger jamesrkiger changed the title [TASK-977] Account routing and sidenav [TASK-977] Switch account sidenav to style module Oct 22, 2024
@jamesrkiger jamesrkiger marked this pull request as ready for review October 22, 2024 13:59
@jamesrkiger jamesrkiger requested a review from duvld October 22, 2024 13:59
Copy link
Member

@duvld duvld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the icons and spacing are 1 or 2 pixels larger. Barely noticeable and I can't find where it's happening. I think it's fine though, no breaking changes.

Copy link

@jamesrkiger
Copy link
Contributor Author

Somehow the icons and spacing are 1 or 2 pixels larger. Barely noticeable and I can't find where it's happening. I think it's fine though, no breaking changes.

Good catch. It was from a css rule I hadn't copied into the style module. Fixed now.

@jamesrkiger jamesrkiger merged commit d067749 into main Nov 1, 2024
6 of 7 checks passed
magicznyleszek added a commit that referenced this pull request Nov 19, 2024
Guitlle pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants