-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(library locking): migrate files to TypeScript #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuukis
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not tested.
See 3 pushed commits - I started a review but quickly figured that it's much easier to show than tell:
- 1st commit - fully used enum elsewhere, and ended up removing the object
- 2nd commit - don't use
let
- 3rd commit - see how
satisfies AssetResponse
instead of: AssetResponse
yields more appropriate typings for the mocks and eliminates the need for the redundant type-guards.
pauloamorimbr
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
Migrating files to TS introduced some non-trivial changes, like:
enum
introduction required some parts of the code to be rewritten (moreif
's etc.)👀 Preview steps
There is a nice long Library Locking Technical Reference article that I feel would be very helpful here :)
Some useful templates for testing:
Testing:
There are three fixes in this PR (mea culpa for not splitting).
First fix: I changed how
isAssetLockable
works, by extending it to also includetemplate
s (previously only allowedsurvey
s). This function works like a feature flag -ish, and I've noticed that with a template that is fully locked (haslock_all: true
), the Form Builder sidebar wasn't all disabled.Second fix: in the same area as above, Background audio setting was not being disabled, and it should be with
lock_all
. I suspect we've added locking before adding Background audio in there and forgot to include it.Third fix: I no longer disabled "Add from Library" and "Layout & Settings" buttons for
lock_all
forms. There is an annoying tiny UX bug that was happening with current code: