Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): incomplete permission removal with “Removed shared project” TASK-1494 #5539

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

Guitlle
Copy link
Contributor

@Guitlle Guitlle commented Feb 19, 2025

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Add a new endpoint to delete all the permissions for a user by deleting any one of the user permissions

👀 Preview steps

  1. Login as a user (user A)
  2. Create or use an existing project to share it with another user (user B)
  3. Log in as user B and go to the project page,
  4. Go to the "Form" tab, and in the three dots button, in the top right corner, click on the option "Remove shared project"
  5. Log out
  6. Log in as user A and check the project sharing settings, the user B should not appear anymore.

@Guitlle Guitlle added API Changes related to API endpoints Back end labels Feb 19, 2025
@Guitlle Guitlle marked this pull request as ready for review February 19, 2025 02:22
@RuthShryock RuthShryock self-requested a review February 19, 2025 13:39
@noliveleger noliveleger changed the title feat(Permissions): Incomplete permission removal with “Removed shared project” TASK-1494 feat(permissions): incomplete permission removal with “Removed shared project” TASK-1494 Feb 19, 2025
Copy link
Member

@RuthShryock RuthShryock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@Guitlle Guitlle merged commit 39e5fa9 into main Feb 20, 2025
4 checks passed
@Guitlle Guitlle deleted the task-1494-delete_all-permissions branch February 20, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes related to API endpoints Back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants