add mint with referral funcionality #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmpc
reviewed
Feb 18, 2025
| } | ||
| payable(owner()).transfer(address(this).balance); |
There was a problem hiding this comment.
it doesn't feel right to use balance as what if minter will send more than needed?
Maybe we should make it equal here? L147
if it's okay, than probably it's the best way
ilmpc
reviewed
Feb 18, 2025
| string memory symbol = "GEN"; | ||
| string memory contractURI = "ipfs://"; | ||
| string memory baseURI = "https://data.kodadot.xyz/base/"; // suffixed with /?hash= | ||
| instance = new BaseGen(initialOwner, name, symbol, contractURI, baseURI, maxSupply, receiver); |
There was a problem hiding this comment.
Could you guide me in the difference between initialOwner and royalty receiver?
Shouldn't that be one entity?
There was a problem hiding this comment.
InitialOwner is the provider (Koda) and receiver is the creator of the art. The logic without referrer was that payment is split in half between Koda and artist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #8