fix helm deploy job vars when only deploy image in somecase #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrusZ
force-pushed
the
fix/helm_deploy_job_vars
branch
from
1764972 to
db8f811
Compare
PetrusZ
changed the title
PetrusZ
force-pushed
the
fix/helm_deploy_job_vars
branch
3 times, most recently
from
5b2b7db to
a44d85f
Compare
Signed-off-by: Patrick Zhao <[email protected]>
PetrusZ
force-pushed
the
fix/helm_deploy_job_vars
branch
from
a44d85f to
06673be
Compare
5 tasks
jamsman94
approved these changes
Dec 24, 2024
jamsman94
added a commit
that referenced
this pull request
Dec 24, 2024
cherry pick #3908 to release 3.2.0
5 tasks
jamsman94
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Revert "fix merge override values order for helm service (#3935) (#3936)" This reverts commit ff888d7. * Revert "fix helm deploy job vars when only deploy image in somecase" This reverts commit 5587a7a. Signed-off-by: Patrick Zhao <[email protected]> --------- Signed-off-by: Patrick Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
fix helm deploy job vars when only update image
What is changed and how it works?
fix helm deploy job vars when only update image
Does this PR introduce a user-facing change?