-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TVH Parental Rating fields #633
Add support for TVH Parental Rating fields #633
Conversation
Looks good in general, but will not be merged for Omega, because kodi does no more accept addon API changes for Omega at this time. So, this has to wait until we started dev cycle for Kodi P. |
@ksooo - Disappointing, but understandable. Do you have an estimate of when this will be? |
You really had bad timing, sorry. No promises, but Omega nearing Beta 2 and usually opening kodi master for dev for next version on RC stage, we are talking not about years, I guess. But as with most FOSS projects, it's done when it's done. ;-) |
src/Tvheadend.cpp
Outdated
if (str){ | ||
rec.SetRatingLabel(str); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the curly braces.
src/Tvheadend.cpp
Outdated
if (str){ | ||
rec.SetRatingIcon(GetImageURL(str)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the curly braces.
08783fb
to
743e71b
Compare
@DeltaMikeCharlie if you want to bring this PR in, you need to close and resubmit it against Piers branch. |
We cannot merge this for Omega, due to API incompatibility. |
Process the existing ‘ageRating’ and the new ‘ratingLabel’ and ‘ratingIcon’ HTSP fields and pass them to the Kodi PVR module.
These fields will be accessible to skins as follows:
ageRating => $INFO[ListItem.ParentalRating]
ratingLabel => $INFO[ListItem.ParentalRatingCode]
ratingIcon => $INFO[ListItem.ParentalRatingIcon]
If ratingAuthority exists => $INFO[ListItem.ParentalRatingSource], otherwise, if ratingCountry exists => $INFO[ListItem.ParentalRatingSource].
Note: The change requires acceptance of the Kodi core PR #24096 containing the modifications to the PVR client API.