Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pointless 'Not all properties handled' log spam. #685

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Fix pointless 'Not all properties handled' log spam. #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pvr.hts/addon.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon
id="pvr.hts"
version="22.4.1"
version="22.4.2"
name="Tvheadend HTSP Client"
provider-name="Adam Sutton, Sam Stenvall, Lars Op den Kamp, Kai Sommerfeld">
<requires>@ADDON_DEPENDS@</requires>
Expand Down
3 changes: 3 additions & 0 deletions pvr.hts/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
v22.4.2
- Fix pointless "Not all properties handled" log spam introduced with v22.4.1

v22.4.1
- Fix pointless "Unknown property" log spam introduced with v22.4.0
- Fix update of "DVR configuration" property not working
Expand Down
6 changes: 0 additions & 6 deletions src/tvheadend/CustomTimerProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ std::vector<kodi::addon::PVRSettingKeyValuePair> CustomTimerProperties::GetPrope
std::vector<kodi::addon::PVRSettingKeyValuePair> customProps;
GetCommonProperties(customProps, rec);

if (customProps.size() < m_propIds.size())
Logger::Log(LogLevel::LEVEL_ERROR, "Not all properties handled!");

return customProps;
}

Expand All @@ -63,9 +60,6 @@ std::vector<kodi::addon::PVRSettingKeyValuePair> CustomTimerProperties::GetPrope
}
}

if (customProps.size() < m_propIds.size())
Logger::Log(LogLevel::LEVEL_ERROR, "Not all properties handled!");

return customProps;
}

Expand Down