-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for InputStreamAdaptive #882
Conversation
This is obsolete already deprecated on Kodi 21
Usually if a service require user-agent header must be set on both manifests and streams
693f2d0
to
6bf0486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Backporting is entirely up to you.
if you’d like this released please add a changelog entry and the verison bump.
i will do, but i wait some days to see if the user of issue give a feedback |
@phunkyfish if you want re-review, i add another commit to fix isa headers/mimetype for all use cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
verson bump commit added here and also on backport PR |
Some code could be simplified a bit if
Use inputstream.adaptive for m3u8 (HLS) streams
setting would instead support all ISA manifest formats, so convert that setting as:Use inputstream.adaptive for streams
. I havent done this change since i have not full picture of the reasons behind this choice (limited to HLS), also i want allow PR to be backported without breaking changes.this pr could be also backported to Omega as is without problems
fix #871