Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for InputStreamAdaptive #882

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

CastagnaIT
Copy link
Contributor

@CastagnaIT CastagnaIT commented Aug 21, 2024

  1. inputstream.adaptive.manifest_type is deprecated on Kodi 21 and removed on Kodi 22
  2. Add missing mimetype for smoothstreaming
  3. Handle user-agent header also on inputstream.adaptive.manifest_headers, this is often a requirement for services, set it only to inputstream.adaptive.stream_headers has no much sense because most of the time will not works
  4. Always set useragent headers and mimetype for inputstream.adaptive, see code comment.

Some code could be simplified a bit if Use inputstream.adaptive for m3u8 (HLS) streams setting would instead support all ISA manifest formats, so convert that setting as: Use inputstream.adaptive for streams. I havent done this change since i have not full picture of the reasons behind this choice (limited to HLS), also i want allow PR to be backported without breaking changes.

this pr could be also backported to Omega as is without problems

fix #871

This is obsolete
already deprecated on Kodi 21
Usually if a service require user-agent header must be set on both manifests and streams
Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Backporting is entirely up to you.

if you’d like this released please add a changelog entry and the verison bump.

@CastagnaIT
Copy link
Contributor Author

Looks good. Backporting is entirely up to you.

if you’d like this released please add a changelog entry and the verison bump.

i will do, but i wait some days to see if the user of issue give a feedback

@CastagnaIT
Copy link
Contributor Author

@phunkyfish if you want re-review, i add another commit to fix isa headers/mimetype for all use cases

Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CastagnaIT
Copy link
Contributor Author

verson bump commit added here and also on backport PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a header for use in the properties of the inputstream adaptive addon (ISA)
2 participants