Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mono fsListType parsing #927

Open
wants to merge 1 commit into
base: Piers
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/iptvsimple/data/Channel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,8 @@ bool Channel::GenerateFlussonicCatchupSource(const std::string& url)
{
if (fsListType == "index")
m_catchupSource = fsHost + "/" + fsChannelId + "/timeshift_rel-{offset:1}.m3u8" + fsUrlAppend;
else if (fsListType == "mono")
Copy link
Member

@phunkyfish phunkyfish Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won’t work I’m afraid as you’re forcing all mono list types to use your format, and for any mono list type they will never reach the following else.

The only way to do this would be to add a new catch format type so that you only test your condition and not any other mono types.

Plus, it would always fail for your format using an index list type.

m_catchupSource = fsHost + "/" + fsChannelId + "/mono-{utc}-{duration}.m3u8" + fsUrlAppend;
else
m_catchupSource = fsHost + "/" + fsChannelId + "/" + fsListType + "-timeshift_rel-{offset:1}.m3u8" + fsUrlAppend;
}
Expand Down