Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Omega] Fix Admin window on GLES / Warn if skin is not supported #203

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

mglae
Copy link
Contributor

@mglae mglae commented Mar 19, 2023

Fix for #141 "Client Specific Settings" were only shown with GL.

HAVE_GLES2 was never defined in FindOpenGLES.cmake. In addition vert.glsl needed to be fixed:

2023-02-27 15:52:04.925 T:1734     info <general>: Loading skin file: /storage/.kodi/addons/pvr.vdr.vnsi/resources/skins/skin.estuary/xml/Admin.xml, load type: LOAD_ON_GUI_INIT
2023-02-27 15:52:04.931 T:1734    debug <general>: [Warning] CGUITextureManager::GetTexturePath: could not find texture '-'
2023-02-27 15:52:04.932 T:1734    error <general>: AddOnLog: pvr.vdr.vnsi: CVertexShader::Compile: 0:10(13): error: `m_proj' undeclared
                                                   0:10(22): error: `m_model' undeclared
                                                   0:10(13): error: operands to arithmetic operators must be numeric
                                                   
2023-02-27 15:52:04.932 T:1734    error <general>: AddOnLog: pvr.vdr.vnsi: GL: Error compiling vertex shader

With this PR the Admin window is visible in LibreELEC Generic (GBM).


Second commit is to add a warning dialog if the skin is not supported.


Increase version to 21.0.1 and update changelog.

I'll create a backport if accepted.

Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution

@phunkyfish
Copy link
Member

Question, why not define HAVE_GLES2 correctly in FindOpenGLES.cmake?

@mglae
Copy link
Contributor Author

mglae commented Mar 20, 2023

Question, why not define HAVE_GLES2 correctly in FindOpenGLES.cmake?

Good question. As HAVE_GLES can only be 2 or 3 it is already the correctly defined HAVE_GLES2.

PR is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants