Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Zoom and Drag & Drop features #74

Closed
wants to merge 1 commit into from

Conversation

rtalexk
Copy link

@rtalexk rtalexk commented Oct 5, 2023

First of all, thanks for your work.

This PR makes the following changes:

  • Add Zoom and Drag & Drop functionality using Panzoom

When there's a large model, it was sort of difficult to navigate.

  • Make the app 'full-screen-like'

Only the sidebar with the Actions, Options and Models is scrollable, the model preview is navigated using the drag & drop feature.

  • Sidebar models overflow

image

Instead of horizontal-scrolling in the sidebar, the text is truncated with elipsis, and it has a tooltip to show the whole content.

  • Diagram & Code Tabs repositioned

I did some CSS changes to make the diagram take the whole available space, with this change I made the buttons absolute positioned, but in the Code tab, it was op top of the text, to prevent this, I moved them to the right, also, I added some opacity, which is set to 100 on hover.

image

And finally, here's a recording of the final result:

mermaid-erd.mov

@unchidev
Copy link
Member

@rtalexk

I'm really happy that you've implemented the feature I wanted!
Please wait for my review 🙏🏿
Thank you!

@unchidev unchidev self-requested a review October 11, 2023 03:05
@unchidev
Copy link
Member

@rtalexk
Considering that text selection and other features would be compromised, I decided to implement it myself.
Thank you for providing the idea.

@rtalexk
Copy link
Author

rtalexk commented Jun 26, 2024

@rtalexk Considering that text selection and other features would be compromised, I decided to implement it myself. Thank you for providing the idea.

Cool. The goal was to have the D&D feature, that's fine with me. I'll close this PR since this is no longer valid.

@rtalexk rtalexk closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants