-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization #131
base: master
Are you sure you want to change the base?
Add localization #131
Conversation
✅ Deploy Preview for koinos-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
components/layout/Menu.js
Outdated
<Link | ||
href={router.asPath} | ||
locale="it" | ||
className={`d-block px-3 py-1 text-decoration-none text-left ${router.locale === 'es' ? 'active' : ''}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste error? locale == 'es'
seems wrong.
components/layout/Menu.js
Outdated
<Link | ||
href={router.asPath} | ||
locale="fa" | ||
className={`d-block px-3 py-1 text-decoration-none text-left ${router.locale === 'es' ? 'active' : ''}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste error? locale == 'es'
seems wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a regression when using the /api/programs
endpoint.
PR:
{
"programs": [
{
"key": "earnOnKoinos",
"id": "earnOnKoinos",
"url": "https://deploy-preview-131--koinos-io.netlify.app/programs/earn-on-koinos",
"website": "http://dapp.chainge.finance/earn?chain=KOIN",
"images": {
"banner": "https://deploy-preview-131--koinos-io.netlify.app/images/programs/earn-on-koinos.png"
},
"featured": true,
"active": true
},
{
"key": "lordsForsakenQuest",
"id": "lordsForsakenQuest",
"url": "https://deploy-preview-131--koinos-io.netlify.app/programs/lords-forsaken-quest",
"website": "https://taskon.xyz/quest/6984752",
"images": {
"banner": "https://deploy-preview-131--koinos-io.netlify.app/images/programs/lords-forsaken-quest.png"
},
"featured": false,
"active": true
}
]
}
Live site:
{
"programs": [
{
"key": "earnOnKoinos",
"url": "https://koinos.io/programs/earn-on-koinos",
"title": "Earn on Koinos",
"subtitle": "Earn up to 16% APY on Koinos!",
"shortDescription": "Chainge Finance and Koinos Group have partnered to offer up to 16.24% yield for simply bridging and holding BTC, ETH, or USDT on Koinos through the Chainge app.",
"description": "Chainge makes Koinos interoperable with over 20 blockchains and their novel DEX aggregation technology delivers some of the lowest cost swaps in all of crypto. High yields and low fees are a powerful flywheel and the Earn on Koinos program kicks it into high gear!",
"keyPoints": [
"Earn up to 16% on bridged assets",
"Earn APY on USDT, ETH, and BTC",
"Earn KOIN with your USDT, ETH, and BTC"
],
"website": "http://dapp.chainge.finance/earn?chain=KOIN",
"images": {
"banner": "https://koinos.io/images/programs/earn-on-koinos.png"
},
"featured": true,
"active": true
}
]
}
During the merge, we left Lord's Forsaken Quest active when it shouldn't be.
But a larger issue is that we are breaking backwards compatibility with our Telegram bot by not providing any text describing programs.
Resolves #129
Brief description
Add localization utilizing next-intl.
Checklist
Demonstration