At70 dark mode #211
Open
At70 dark mode #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elevation2: #ffff, | ||
| elevation3: #ffff, | ||
| elevation4: #ffff, | ||
| elevation5: #ffff, |
There was a problem hiding this comment.
What's the difference between elevation 1 till 5?
There was a problem hiding this comment.
Do we also need 5 different elevations? Or how much do we actually use. Same goes for dark theme a few lines below.
There was a problem hiding this comment.
All elevations are currently in use in the dark mode. Most of the elevations in light mode are white cause we don't use any visual elevation in the design. However they need to exist as a counterpart for the dark mode.
added 3 commits
June 14, 2022 22:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated dark mode.
source used:
https://javascript.plainenglish.io/the-best-way-to-add-dark-mode-to-your-react-sass-project-ce3ae3bd8616