-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At70 dark mode #211
base: develop
Are you sure you want to change the base?
At70 dark mode #211
Conversation
elevation2: #ffff, | ||
elevation3: #ffff, | ||
elevation4: #ffff, | ||
elevation5: #ffff, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between elevation 1 till 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need 5 different elevations? Or how much do we actually use. Same goes for dark theme a few lines below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All elevations are currently in use in the dark mode. Most of the elevations in light mode are white cause we don't use any visual elevation in the design. However they need to exist as a counterpart for the dark mode.
Incorporated dark mode.
source used:
https://javascript.plainenglish.io/the-best-way-to-add-dark-mode-to-your-react-sass-project-ce3ae3bd8616