Merge pull request #84 from koji-1009/refactor

Refactor
koji-1009 · Jan 5, 2022 · 32ad427 · 32ad427
2 parents dc3cb52 + 01b929e
commit 32ad427
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/...ter_auth_ui/android/src/main/java/com/dr1009/app/flutter_auth_ui/FlutterAuthUiPlugin.java b/...ter_auth_ui/android/src/main/java/com/dr1009/app/flutter_auth_ui/FlutterAuthUiPlugin.java
@@ -209,7 +209,7 @@ private void startUi(@NonNull MethodCall call, @NonNull Result result) {
                     case "Apple":
                         providers.add(new AuthUI.IdpConfig.AppleBuilder().build());
                         break;
-                    case "Github":
+                    case "GitHub":
                         providers.add(new AuthUI.IdpConfig.GitHubBuilder().build());
                         break;
                     case "Microsoft":

diff --git a/flutter_auth_ui/ios/Classes/SwiftFlutterAuthUiPlugin.swift b/flutter_auth_ui/ios/Classes/SwiftFlutterAuthUiPlugin.swift
@@ -158,7 +158,7 @@ public class SwiftFlutterAuthUiPlugin: NSObject, FlutterPlugin, FUIAuthDelegate
                 if #available(iOS 13.0, *) {
                     providers.append(FUIOAuth.appleAuthProvider())
                 }
-            case "Github" :
+            case "GitHub" :
                 providers.append(FUIOAuth.githubAuthProvider())
             case "Microsoft" :
                 providers.append(FUIOAuth.microsoftAuthProvider())

diff --git a/flutter_auth_ui/lib/flutter_auth_ui.dart b/flutter_auth_ui/lib/flutter_auth_ui.dart
@@ -62,7 +62,7 @@ extension _AuthUiProviderExt on AuthUiProvider {
       case AuthUiProvider.apple:
         return 'Apple';
       case AuthUiProvider.github:
-        return 'Github';
+        return 'GitHub';
       case AuthUiProvider.microsoft:
         return 'Microsoft';
       case AuthUiProvider.yahoo:

diff --git a/flutter_auth_ui_web/lib/flutter_auth_ui_web.dart b/flutter_auth_ui_web/lib/flutter_auth_ui_web.dart
@@ -94,8 +94,13 @@ class FlutterAuthUiWeb {
     final privacyPolicyUrl = args['privacyPolicyUrl'];
 
     // get flutter web's main view
-    final fltGlassPane = html.window.document
-        .getElementsByTagName('flt-glass-pane')[0] as html.Element;
+    final fltGlassPane = html.window.document.querySelector('flt-glass-pane');
+    if (fltGlassPane == null) {
+      throw PlatformException(
+        code: 'IllegalStateException',
+        details: 'Failed to locate <flt-glass-pane>',
+      );
+    }
 
     final containerDiv = html.Element.div();
     // add div element instead of 'firebaseui-auth-container' div