Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite code entirely #24

Merged
merged 40 commits into from
Jan 30, 2018
Merged

Rewrite code entirely #24

merged 40 commits into from
Jan 30, 2018

Conversation

koji-kojiro
Copy link
Owner

The source code was entirely rewritten to improve stability and maintainability.
This closes #12, closes #17, closes #23 .

@koji-kojiro koji-kojiro changed the title Entirely rewritten code Rewrite code entirely Jan 30, 2018
@koji-kojiro koji-kojiro merged commit 02c39c1 into master Jan 30, 2018
src/main.lisp Outdated
:long "version"))

(defun main (argv &key (show-logo t))
(multiple-value-bind (options free-args)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! I like this way of parsing arguments. If by chance my code helped, I'm glad it did :)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks a lot!
However, I could not build an executable with asdf ...
To be accurate, the build succeeded, but the executable did not work, caused SB-SYS: MEMORY-FAULT-ERROR.
I'm not sure where this error comes.
Do you have any ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't encounter this error. I had once a "heap exhausted error" and it was a recursion error in a (new-ish) third-party library.

If you put your attempt in a new branch I'm ok to try, and at least say if I reproduce the pb.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please.
I'll create the branch and put comment on #19 later.

@koji-kojiro koji-kojiro deleted the refactor branch January 30, 2018 12:37
@koji-kojiro koji-kojiro mentioned this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter with no-input enters the debugger and then fails Prompt becomes "NIL>" when *package* has no nicknames
2 participants