-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AES-128-CFB mode and it's test code. #182
base: master
Are you sure you want to change the base?
Conversation
aes.h
Outdated
#endif // #if defined(CTR) && (CTR == 1) | ||
#endif // #if defined(CFB) && (CFB == 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should revert to the original line since the #if
is for CTR
In aes.h/c, the code guarded by |
Already fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking for a CFB mode implementation, and thankfully, I found this.
The code looks well structured and seems functional, I don't see why this hasn't been merged yet. @kokke , perhaps you want to take a look at this.
Hi kokke:
I write a small piece of code to support CFB mode.
I think the code style is quite like the CFB part.
And I generated the test sample by a small golang program and paste the results into test code.
May this is helpful to others.