Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in team_member.reduce sample code snippet #634

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Fix inconsistency in team_member.reduce sample code snippet #634

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6dcf5e
Fix inconsistency in ``team_member.reduce`` sample code snippet
mabruzzo Feb 24, 2025
54f1a98
Update docs/source/ProgrammingGuide/HierarchicalParallelism.md
mabruzzo Feb 24, 2025
787b171
Further improve `team_member.team_reduce` sample-snippet by using `Ko…
mabruzzo Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions docs/source/ProgrammingGuide/HierarchicalParallelism.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ Kokkos::TeamPolicy<SomeTag, ExecutionSpace>
The team policy's `member_type` provides the necessary functionality to use teams within a parallel kernel. It allows access to thread identifiers such as the league rank and size, and the team rank and size. It also provides team-synchronous actions such as team barriers, reductions and scans.

```c++
using Kokkos::atomic_add;
using Kokkos::PerTeam;
using Kokkos::Sum;
using Kokkos::TeamPolicy;
using Kokkos::parallel_for;

Expand All @@ -73,12 +76,17 @@ TeamPolicy<ExecutionSpace> policy (league_size, Kokkos::AUTO() );
// Launch a kernel
parallel_for (policy, KOKKOS_LAMBDA (member_type team_member) {
// Calculate a global thread id
int k = team_member.league_rank () * team_member.team_size () +
int k = team_member.league_rank () * team_member.team_size () +
team_member.team_rank ();

// Calculate the sum of the global thread ids of this team
int team_sum = team_member.reduce (k);
// Atomically add the value to a global value
a() += team_sum;
int team_sum = k;
team_member.team_reduce(Sum<int, typename ExecutionSpace::memory_space>(team_sum));

// Atomically add the computed sum to a global value
Kokkos::single (PerTeam (team_member), [=] () {
atomic_add(&global_value(), team_sum);
});
});
```

Expand Down