add option for stdmode install #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
May 3, 2023
|
You mean you defaulted to off right? |
woops yeah |
crtrott
approved these changes
May 3, 2023
|
I think this is ok. |
nmm0
force-pushed
the
add-option-for-stdmode-install
branch
from
862cac4 to
27a36c8
Compare
nmm0
force-pushed
the
add-option-for-stdmode-install
branch
from
27a36c8 to
2496616
Compare
…darray.hpp are installed
nmm0
force-pushed
the
add-option-for-stdmode-install
branch
from
2496616 to
4ab7984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyway, this PR adds a new CMake option,
MDSPAN_INSTALL_STDMODE_HEADERSthat will disable installing the std-like headers<experimental/mdspan>and<experimental/mdarray>. This will hopefully avoid conflicts with any standard library that actually ships mdspan if the user is not intending to use these headers (including ones that ship this library :P). I've defaulted this toOFFwhich is technically a breaking change so I can switch that around. However, in general I think it shouldn't be on by default.Also, I realized that
<mdspan/mdspan.hpp>and<mdspan/mdarray.hpp>were not installed, so this fixes that too.