Fix warnings (shadow and conversion) #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
changed the title
mhoemmen
approved these changes
Jun 4, 2024
| @@ -651,15 +651,15 @@ constexpr void validate_strides(with_rank<N>, Layout, const Extents& ext, const | |||
|
|
|||
| constexpr auto is_left = std::is_same<Layout, layout_left>::value; | |||
|
|
|||
| typename Extents::index_type stride = 1; | |||
| typename Extents::index_type stride_ = 1; | |||
There was a problem hiding this comment.
Should we consider avoiding use of trailing underscore for variables that aren't nonpublic data members of the class?
Suggested change
| typename Extents::index_type stride_ = 1; | |
| typename Extents::index_type the_stride = 1; |
| and "invalid strides for layout_{left,right}"); | ||
|
|
||
| stride *= ext.extent(s); | ||
| stride_ *= ext.extent(s); |
There was a problem hiding this comment.
Suggested change
| stride_ *= ext.extent(s); | |
| the_stride *= ext.extent(s); |
There was a problem hiding this comment.
renamed to expected_stride
crtrott
force-pushed
the
fix_shadow_warning
branch
from
b59a26d to
6a7bcc6
Compare
|
I don't think our CI is actually testing Wshadow |
Looks like the GitHub Workflows don't test with any warning flags and https://github.com/kokkos/mdspan/blob/stable/README.md#running-tests mentions that a lot of the configurations would not build with warnings as errors (depending on the C++ standard). |
I know. But we can touch CI separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extent and stride thing shadow something new in utility.hpp