ENH: add() to API standard #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bring `add()` ufunc up to API standard and turn its test on in the CI * many of the other changes are the same as described in other recent binary ufunc PRs * one drawback to our current approach to broadcasting, which is more apparent in the diff here, is that we simply copy data into the largest common shape, which isn't exactly efficient
tylerjereddy
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring
add()ufunc up to API standard and turn its test on in the CImany of the other changes are the same as described in other recent binary ufunc PRs
one drawback to our current approach to broadcasting, which is more apparent in the diff here, is that we simply copy data into the largest common shape, which isn't exactly efficient