New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP, ENH: remainder() to API standard #162

Open

tylerjereddy wants to merge 2 commits into kokkos:main from tylerjereddy:treddy_remainder_api_std

Commits on Jan 20, 2023

ENH: remainder() to API standard

* draft the `remainder()` ufunc and turn its matching array API
standad test on in the CI; many of the other changes reflect
those in recent binary ufunc PRs

* note that the implementation of the remainder is actually
rather non-trivial here; for reference, the reviewer may
want to check the following, and perhaps also the NumPy
inner loop implementation:
  - https://stackoverflow.com/a/1907585/2942522
  - https://data-apis.org/array-api/latest/API_specification/generated/array_api.remainder.html

tylerjereddy committed Jan 20, 2023

Commits on Jan 21, 2023

MAINT, BUG: PR 162 revisions

* fix up some of the `remainder()` workunits that were
failing array API standard test

* still needs more work though--for floating type cases
I need to conform to the special cases noted here more closely:
https://data-apis.org/array-api/latest/API_specification/generated/array_api.remainder.html

[skip actions]

tylerjereddy committed Jan 21, 2023