Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password with special characters needs to be unquoted #12

Closed
sualk opened this issue May 29, 2022 · 8 comments
Closed

Password with special characters needs to be unquoted #12

sualk opened this issue May 29, 2022 · 8 comments

Comments

@sualk
Copy link

sualk commented May 29, 2022

Scan an connect fails if the password contains a special character like ",", eg "123,ab"
In that case the password gets set as "123,ab", an additional \ is added.

The password and possibly also the SSID needs to be unquoted before further use.

@kokoye2007
Copy link
Owner

I will test and use to hash. It's possible :)

Thanks for your help.

@kokoye2007
Copy link
Owner

qrencode is strip
special character < Reserved Characters >

@sualk
Copy link
Author

sualk commented Oct 17, 2022

Maybe i did not describe the problem well enough and i also noted that one \ is missing in my initial report.

If you have a WIFI network with some special characters in the password then these characters should be quoted in the QR code as described here: https://github.com/zxing/zxing/wiki/Barcode-Contents#wi-fi-network-config-android-ios-11

So the WIFI password is "123,abc", but the QR contains the following "123\,abc".

Scanning this QR code with wifi-qr will use the password with the additional \ instead of the correct one without the \.
So before using the password data from the QR code an unquoting is required to generate the correct password.

kokoye2007 added a commit that referenced this issue Apr 19, 2023
kokoye2007 added a commit that referenced this issue Apr 19, 2023
kokoye2007 added a commit that referenced this issue Apr 19, 2023
kokoye2007 added a commit that referenced this issue Apr 19, 2023
@kokoye2007
Copy link
Owner

@ls-1N
Copy link
Contributor

ls-1N commented Apr 20, 2023

It worked for me with a password that has @ in it. 👍

@kokoye2007 Btw is it intentional that you didn't upload a .deb file in the 0.2.3 release?

@kokoye2007
Copy link
Owner

@ls-1N apologies
I will update ASAP with

  • SSID name instead SSID File Name
  • SSID special characters as well.

next release will be .deb and archive :D
Thank for your support.

@kokoye2007 kokoye2007 reopened this Apr 21, 2023
kokoye2007 added a commit that referenced this issue Apr 25, 2023
kokoye2007 added a commit that referenced this issue Apr 25, 2023
@kokoye2007
Copy link
Owner

It worked for me with a password that has @ in it. +1

@kokoye2007 Btw is it intentional that you didn't upload a .deb file in the 0.2.3 release?

https://github.com/kokoye2007/wifi-qr/releases/tag/wifi-qr-0.2-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants