Add message when there are other page bookmarks with the same name

kommunarr · Jun 11, 2024 · 094b2c2 · 094b2c2
1 parent e5b5b43
commit 094b2c2
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js b/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js
@@ -24,6 +24,16 @@ export default defineComponent({
     isBookmarkBeingCreated: function () {
       return this.pageBookmark == null
     },
+    pageBookmarks: function () {
+      return this.$store.getters.getPageBookmarks
+    },
+    duplicateNameCount: function () {
+      const currentBookmarkAdjustment = this.name === this.pageBookmark?.name ? -1 : 0
+      return currentBookmarkAdjustment + this.pageBookmarks.filter((pageBookmark) => pageBookmark.name === this.name).length
+    },
+    duplicateNameMessage: function () {
+      return this.$tc('Page Bookmark["There is {count} other bookmark with the same name."]', this.duplicateNameCount, { count: this.duplicateNameCount })
+    },
     pageBookmark: function () {
       return this.$store.getters.getPageBookmarkWithRoute(this.$router.currentRoute.fullPath)
     },

diff --git a/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.vue b/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.vue
@@ -20,6 +20,9 @@
         @clear="e => name = ''"
         @keydown.enter.native="save"
       />
+      <ft-flex-box v-if="duplicateNameCount > 0">
+        <p>{{ duplicateNameMessage }}</p>
+      </ft-flex-box>
     </div>
     <div class="actions-container">
       <ft-flex-box>

diff --git a/src/renderer/store/modules/search-history.js b/src/renderer/store/modules/search-history.js
@@ -5,7 +5,7 @@ const state = {
 }
 
 const getters = {
-  getPageBookmarks: (state) => () => {
+  getPageBookmarks: (state) => {
     return state.pageBookmarks
   },
 

diff --git a/static/locales/en-US.yaml b/static/locales/en-US.yaml
@@ -1116,6 +1116,7 @@ Page Bookmark:
   Created page bookmark: Created page bookmark "{name}"
   Updated page bookmark: Updated page bookmark "{name}"
   Removed page bookmark: Removed page bookmark "{name}"
+  There is {count} other bookmark with the same name.: There is {count} other page bookmark with the same name. | There are {count} other page bookmarks with the same name.
 Role Descriptions:
   bookmark: bookmark
 Moments Ago: moments ago