Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digest field to image block in values.yaml #560

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

unitmatrix
Copy link
Contributor

This pull request adds a digest field to the image block in the values.yaml file. The digest field allows specifying the exact image digest to pull, ensuring that the correct image version is used.

Changes include:

  • Added digest field to the image block in values.yaml

This change does not introduce any breaking changes and is backward compatible. The digest field is already utilized in the _helpers.tpl file, ensuring that the specified digest is used when constructing the image name.

@undera
Copy link
Collaborator

undera commented Nov 21, 2024

What happens if digest is not specified? Will it work as before?

@unitmatrix
Copy link
Contributor Author

If the digest field is not specified, the behavior will remain the same as before. The image will be pulled based on the tag field or the default chart appVersion if the tag is not specified. The digest field is optional and only used when explicitly provided, ensuring backward compatibility and no changes to the existing functionality.

@undera undera merged commit f85343a into komodorio:main Nov 21, 2024
4 checks passed
@undera
Copy link
Collaborator

undera commented Nov 21, 2024

Thank you for explaining

@unitmatrix unitmatrix deleted the add-image-digest-field branch November 21, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants