Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor helm-dashboard.fullname template for better readability #562

Merged

Conversation

unitmatrix
Copy link
Contributor

This pull request refactors the helm-dashboard.fullname template in the _helpers.tpl file to improve readability and maintainability. The changes include:

  • Introducing a $fullname variable to store the full name.
  • Adjusting the indentation and formatting for better clarity.

@undera
Copy link
Collaborator

undera commented Nov 25, 2024

Please look at CI failing

@unitmatrix unitmatrix force-pushed the refactor/fullname-template-readability branch from 6ddb863 to f27616d Compare November 25, 2024 09:56
@undera undera merged commit 3b0b44f into komodorio:main Nov 25, 2024
4 checks passed
@unitmatrix unitmatrix deleted the refactor/fullname-template-readability branch November 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants