Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle Cluster Names with Slashes in Helm Dashboard UI #563

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

unitmatrix
Copy link
Contributor

This PR addresses issue #557 by ensuring that the Helm Dashboard UI is accessible even if the cluster name contains a slash. The changes include:

  • Added necessary encoding to the navigation path to prevent routing issues.
  • Implemented decoding of cluster names to ensure proper display and functionality.

Closes #557.

remove redundant code

correct encode decode
@undera
Copy link
Collaborator

undera commented Nov 26, 2024

This is very nice! Thank you!

@undera undera merged commit 69fe906 into komodorio:main Nov 26, 2024
4 checks passed
@unitmatrix unitmatrix deleted the fix/conntent-decoding branch December 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Dashboard UI not accessible if cluster name contains slash
2 participants