gitops-pull-request: skip EC when no image changed

task/gather-deploy-images: Return a "boolean" result that indicates whether there are any images to check. --- pipelines/gitops-pull-request-rhtap: Run the EC task only if gather-deploy-images gathers some images. Otherwise, the last step of the task (assert) would fail. Signed-off-by: Adam Cmiel <[email protected]>
konflux-ci · Mar 19, 2024 · 1955039 · 1955039
1 parent d1bee10
commit 1955039
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/pipelines/gitops-pull-request-rhtap/gitops-pull-request.yaml b/pipelines/gitops-pull-request-rhtap/gitops-pull-request.yaml
@@ -82,6 +82,10 @@ spec:
           value: $(params.ec-tuf-mirror)
       runAfter:
         - gather-deploy-images
+      when:
+        - input: $(tasks.gather-deploy-images.results.NOTHING_TO_VERIFY)
+          operator: notin
+          values: ["true"]
       taskRef:
         name: verify-enterprise-contract
         version: "0.1"
diff --git a/task/gather-deploy-images/0.1/README.md b/task/gather-deploy-images/0.1/README.md
@@ -11,6 +11,7 @@ Extract images from deployment YAML to pass to EC for validation
 |name|description|
 |---|---|
 |IMAGES_TO_VERIFY|The images to be verified, in a format compatible with https://github.com/redhat-appstudio/build-definitions/tree/main/task/verify-enterprise-contract/0.1|
+|NOTHING_TO_VERIFY|"true" if there are no images to be verified, "false" otherwise|
 
 ## Workspaces
 |name|description|optional|

diff --git a/task/gather-deploy-images/0.1/gather-deploy-images.yaml b/task/gather-deploy-images/0.1/gather-deploy-images.yaml
@@ -19,6 +19,8 @@ spec:
   results:
     - name: IMAGES_TO_VERIFY
       description: The images to be verified, in a format compatible with https://github.com/redhat-appstudio/build-definitions/tree/main/task/verify-enterprise-contract/0.1
+    - name: NOTHING_TO_VERIFY
+      description: '"true" if there are no images to be verified, "false" otherwise'
   steps:
   - name: get-images-per-env
     image: quay.io/redhat-appstudio/appstudio-utils:5bd7d6cb0b17f9f2eab043a8ad16ba3d90551bc2@sha256:8c7fcf86af40c71aeb58e4279625c8308af5144e2f6b8e28b0ec7e795260e5f7
@@ -61,3 +63,6 @@ spec:
           "components": map({"containerImage": .})
         }
       ' | tee $(results.IMAGES_TO_VERIFY.path)
+
+      nothing_to_verify=$(jq '.components | length == 0' $(results.IMAGES_TO_VERIFY.path))
+      printf "%s" "$nothing_to_verify" > $(results.NOTHING_TO_VERIFY.path)