Skip to content

Commit

Permalink
tasks: Use set -e in rpm-ostree task
Browse files Browse the repository at this point in the history
Related to https://gitlab.com/redhat/centos-stream/containers/bootc/-/merge_requests/248

Basically a while ago the rpm-ostree task was forked from the buildah
task and we didn't inherit the later change to use `set -e` (as we should)
on the inner shell script, meaning we had the default "blindly stumble forward
when we hit an error" which is never what we want.

This would have helped focus the problem on cachi2, not selinux.

Signed-off-by: Colin Walters <[email protected]>
  • Loading branch information
cgwalters authored and arewm committed Oct 8, 2024
1 parent dab4840 commit f9b9f50
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions task/rpm-ostree/0.2/rpm-ostree.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ spec:
cat >scripts/script-build.sh <<'REMOTESSHEOF'
#!/bin/sh
set -o verbose
set -eu
set -o pipefail
cd $(workspaces.source.path)
if [ -z "$CONFIG_FILE" ] ; then
CONFIG_FILE_ARG=""
Expand Down

0 comments on commit f9b9f50

Please sign in to comment.