Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --all when building manifests #1042

Merged
merged 1 commit into from
Jul 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions task/build-image-manifest/0.1/build-image-manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ spec:
value: $(params.IMAGE)
- name: TLSVERIFY
value: $(params.TLSVERIFY)
- name: COMMIT_SHA
value: $(params.COMMIT_SHA)
steps:
- image: quay.io/redhat-appstudio/buildah:v1.31.0@sha256:34f12c7b72ec2c28f1ded0c494b428df4791c909f1f174dd21b8ed6a57cf5ddb
# per https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting
Expand All @@ -56,9 +58,6 @@ spec:
requests:
memory: 512Mi
cpu: 250m
env:
- name: COMMIT_SHA
value: $(params.COMMIT_SHA)
args: ["$(params.IMAGES[*])"]
script: |
#!/bin/bash
Expand All @@ -79,7 +78,7 @@ spec:
TOADD="$(echo $i | cut -d: -f1)@sha256:$(echo $i | cut -d: -f3)"
fi
echo "Adding $TOADD"
buildah manifest add $IMAGE "docker://$TOADD"
buildah manifest add $IMAGE "docker://$TOADD" --all
done

status=-1
Expand Down