Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to build RHEL AI #1059

Closed
wants to merge 21 commits into from

Conversation

stuartwdouglas
Copy link
Contributor

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@stuartwdouglas stuartwdouglas force-pushed the build-bootc-vm branch 3 times, most recently from fe35af3 to cd2c66b Compare June 24, 2024 21:00
@stuartwdouglas
Copy link
Contributor Author

/retest

@stuartwdouglas
Copy link
Contributor Author

/retest

@stuartwdouglas stuartwdouglas force-pushed the build-bootc-vm branch 2 times, most recently from cd4837c to 2bcb29d Compare June 28, 2024 01:02
@ralphbean
Copy link
Member

/retest

@ralphbean
Copy link
Member

Looks like this is failing yaml-lint-check @stuartwdouglas.

task/build-vm-image/0.1/build-vm-image.yaml Show resolved Hide resolved
type: string
- name: OUTPUT_IMAGE
type: string
description: The output manifest list that points to the OCI artifact of the zipped ZM image
Copy link
Collaborator

@mmorhun mmorhun Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's ZM? Is it a typo? If not, could you expand it in the description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ralphbean@71b679b.

task/build-vm-image/0.1/build-vm-image.yaml Show resolved Hide resolved
echo "declare SOURCE_IMAGE=${SOURCE_IMAGE}" >> /var/workdir/vars

# here we should validate that both keys exist and are valid pullspecs.
# todo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional for this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 2903e81.

- name: etc-pki-entitlement
secret:
optional: true
secretName: $(params.ENTITLEMENT_SECRET)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ralphbean@a6a4a63.

@ralphbean ralphbean mentioned this pull request Jul 8, 2024
@ralphbean
Copy link
Member

Closing this in favor of #1133.

@ralphbean ralphbean closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants