Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Checkton workflow #1085

Closed
wants to merge 6 commits into from
Closed

Add Checkton workflow #1085

wants to merge 6 commits into from

Conversation

chmeliik
Copy link
Contributor

@chmeliik chmeliik commented Jun 21, 2024 •
edited
Loading

This PR demonstrates Checkton's features, such as...

  • When a file is renamed, do not treat it as a completely new file. Report only new issues introduced in the PR
  • When a file is copied (e.g. creating a new version of a task), report only new issues compared to the source file

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 21, 2024
View reviewed changes
task/buildah/0.1/buildah.yaml
@@ -268,7 +268,7 @@

unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \
$VOLUME_MOUNTS \
"${BUILDAH_ARGS[@]}" \
${BUILDAH_ARGS[@]} \

Check failure

Code scanning / shellcheck

SC2068 Error

Double quote array expansions to avoid re-splitting elements.
task/buildah/0.1/buildah.yaml
@@ -268,7 +268,7 @@

unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \
$VOLUME_MOUNTS \
"${BUILDAH_ARGS[@]}" \
${BUILDAH_ARGS[@]} \

Check warning

Code scanning / shellcheck

SC3054 Warning

In POSIX sh, array references are undefined.
task/prefetch-dependencies/0.2/prefetch-dependencies.yaml
mountPath: /mnt/trusted-ca
readOnly: true
script: |
if [ -z ${INPUT} ]

Check warning

Code scanning / shellcheck

SC2086 Warning

Double quote to prevent globbing and word splitting.
.tekton/pr.yaml
@@ -248,6 +248,7 @@
image: registry.redhat.io/openshift4/ose-cli:v4.12@sha256:0d21299d2adfa3cb74562c4dffbedd3b107fffac3a2a537f14770088abd4671f
script: |
#!/usr/bin/env bash
echo $HI

Check warning

Code scanning / shellcheck

SC2086 Warning

Double quote to prevent globbing and word splitting.
@chmeliik chmeliik mentioned this pull request Jul 9, 2024
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2024
View reviewed changes
task/buildah/0.1/buildah.yaml
@@ -268,7 +270,7 @@

unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \
$VOLUME_MOUNTS \
"${BUILDAH_ARGS[@]}" \
${BUILDAH_ARGS[@]} \

Check failure

Code scanning / shellcheck

SC2068 Error

Double quote array expansions to avoid re-splitting elements.
@chmeliik
Add Checkton workflow
e10b9bb 
Based on https://github.com/chmeliik/checkton#example-usage

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
mv .tekton/pull-request.yaml -> .tekton/pr.yaml
ab86b8f 
Checkton should not report any warnings

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
add problematic bash code to .tekton/pr.yaml
7d1f3fc 
Checkton should only report the new addition

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
cp prefetch-dependencies/{0.1 -> 0.2}
f044306 
Checkton should not report any warnings

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
add bash problem to prefetch-dependencies/0.2
3dd6dc0 
Checkton should only report the new problem

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
add bash problem to buildah.yaml
020fd2f 
While at the same time, fixing another problem by using a more accurate
shebang

Signed-off-by: Adam Cmiel <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2024
View reviewed changes
task/buildah/0.1/buildah.yaml
@@ -308,7 +310,7 @@

unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \
$VOLUME_MOUNTS \
"${BUILDAH_ARGS[@]}" \
${BUILDAH_ARGS[@]} \

Check failure

Code scanning / shellcheck

SC2068 Error

Double quote array expansions to avoid re-splitting elements.
@chmeliik
Copy link
Contributor Author

Adding for real in #1183

@chmeliik chmeliik closed this Jul 23, 2024
@chmeliik chmeliik deleted the test-checkton branch July 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chmeliik