fix: remove duplicate volumeMounts from oci-copy-oci-ta #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Everett
approved these changes
Jun 24, 2024
ralphbean
approved these changes
Jun 25, 2024
|
Oh, wait - we need to reconcile this with what |
|
@14rcole how did you notice this, btw? |
This was referenced Jun 25, 2024
|
@ralphbean I was debugging issues with #1088 and after a rebase I started running into this error: What is |
The oci-copy-oci-ta task had two volumeMounts with the same name and mounting location, which would cause an error when the task was applied to a cluster. This change removes the duplicate Signed-off-by: Ryan Cole <[email protected]>
14rcole
force-pushed
the
remove-duplicate-volumemounts
branch
from
8283436
to
69f55c5
Compare
|
That's fine with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oci-copy-oci-ta task had two volumeMounts with the same name and mounting location, which would cause an error when the task was applied to a cluster. This change removes the duplicate
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.