Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-image-manifest readme #1094

Merged

Conversation

mkosiarc
Copy link
Contributor

@mkosiarc mkosiarc commented Jun 25, 2024

The task generates image index, that contains info about individual arch-specific image manifests and not the image manifests themselves.

KFLUXBUGS-1145

The task generates image index, that contains info about individual
arch-specific image manifests and not the image manifests themselves.

KFLUXBUGS-1145

Signed-off-by: mkosiarc <[email protected]>
@mkosiarc
Copy link
Contributor Author

I feel like this is tiny semantic issue, this short change seems sufficient to me. But if you prefer more details, let me know.

Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantic change is helpful. I had also considered creating a new task that is named build-image-index. That would be beneficial to do before creating a multi-platform pipeline to further reduce confusion.

@mkosiarc mkosiarc added this pull request to the merge queue Jul 5, 2024
Merged via the queue into konflux-ci:main with commit 12f31d3 Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants