Add an architecture suffix to images pushed for multi-platform if missing #1185
Conversation
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
8 times, most recently
from
28d8820
to
d0ae2cd
Compare
arewm
changed the title
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
6 times, most recently
from
ccbd82e
to
6c066ea
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
6c066ea
to
2ea2ad7
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
6 times, most recently
from
d28bb14
to
1ee4628
Compare
arewm
changed the title
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
1ee4628
to
f886065
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
8f0c86a
to
468b729
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
468b729
to
41b1eff
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
41b1eff
to
824d09a
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
6 times, most recently
from
af89669
to
39ee314
Compare
task-generator/remote/main.go
Outdated
| step := &task.Spec.Steps[stepPod] | ||
| if step.Name != "build" { | ||
| if step.Script != "" && taskVersion == "0.2" && step.Name != "build" { |
There was a problem hiding this comment.
I'm afraid, that supporting many task versions is error prone.
Should we support only latest buildah task version?
There was a problem hiding this comment.
We cannot easily add this to v0.1 because we don't have IMAGE_REF to fall back on to when we change the image tag that is produced.
There was a problem hiding this comment.
Can we mark the other versions as deprecated?
We did this here.
That makes EC not trust those Tasks any longer (at that given time). This should be sufficient to make users upgrade.
There was a problem hiding this comment.
Interesting. We should probably mark all tasks which produce or consume the BASE_IMAGE_DIGESTS as deprecated together. I think that should be done outside of the current PR.
| if !strings.HasPrefix(ret, "#!") { | ||
| // If there is a shebang, it is explicitly non-bash, so don't adjust the image |
There was a problem hiding this comment.
Another often used option is #!/bin/sh
There was a problem hiding this comment.
If it is not bash, we cannot inject the remote image adjustment. We cannot design for all potential cases that we might encounter so we just bail out and then can address the cases in the future.
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
39ee314
to
50b3e1b
Compare
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
50b3e1b
to
d36378f
Compare
In order to reduce the likelihood of users accidentally forgetting to specify unique tags for each architecture, we can add a suffix to the pushed image if an arch-specific one doesn't exist. Signed-off-by: arewm <[email protected]>
arewm
force-pushed
the
add-arch-to-multi-platform-images
branch
from
d36378f
to
02e1a9c
Compare
In order to reduce the likelihood of users accidentally forgetting to specify unique tags for each architecture, we can add a suffix to the pushed image
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.