-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprinkle some log statements in inject-and-push #1219
Conversation
Just to help users see what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small nitpick
And in my opinion it's not necessary to update the older versions of tasks. Though we don't have any versioning policy yet.
f92447d
to
eafaec2
Compare
/retest |
task/buildah/0.1/buildah.yaml
Outdated
buildah copy $container sbom-cyclonedx.json sbom-purl.json /root/buildinfo/content_manifests/ | ||
echo "Re-applying base image annotations and labels" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Re-applying base image annotations and labels" | |
echo "Re-applying base image annotations" |
Here as well, if we're keeping the 0.1
changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, how did I miss that. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding old task versions, I'd like to add it anyways since - it's for me. I need the visual aid when reviewing the output of buildah tasks and trying to confirm that manifests are being injected where they should be.
(Long story, but the ai-lab images are so huge that ec times out trying to verify that the files exist in /root/buildinfo/, but it appears to suppress the timeout and instead just reports that the files are missing. Related to enterprise-contract/ec-cli#1788)
No labels are being applied here. Co-authored-by: Adam Cmiel <[email protected]>
eafaec2
to
5bd7b3d
Compare
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull request was closed
Just to help users see what's going on.