Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprinkle some log statements in inject-and-push #1219

Closed
wants to merge 2 commits into from

Conversation

ralphbean
Copy link
Member

Just to help users see what's going on.

Just to help users see what's going on.
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nitpick

And in my opinion it's not necessary to update the older versions of tasks. Though we don't have any versioning policy yet.

task/buildah/0.2/buildah.yaml Outdated Show resolved Hide resolved
@ralphbean
Copy link
Member Author

/retest

buildah copy $container sbom-cyclonedx.json sbom-purl.json /root/buildinfo/content_manifests/
echo "Re-applying base image annotations and labels"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Re-applying base image annotations and labels"
echo "Re-applying base image annotations"

Here as well, if we're keeping the 0.1 changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, how did I miss that. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding old task versions, I'd like to add it anyways since - it's for me. I need the visual aid when reviewing the output of buildah tasks and trying to confirm that manifests are being injected where they should be.

(Long story, but the ai-lab images are so huge that ec times out trying to verify that the files exist in /root/buildinfo/, but it appears to suppress the timeout and instead just reports that the files are missing. Related to enterprise-contract/ec-cli#1788)

No labels are being applied here.

Co-authored-by: Adam Cmiel <[email protected]>
@chmeliik chmeliik enabled auto-merge July 31, 2024 12:37
@chmeliik
Copy link
Contributor

chmeliik commented Aug 1, 2024

/retest

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ralphbean ralphbean closed this Sep 10, 2024
auto-merge was automatically disabled September 10, 2024 18:18

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants