feat(RHTAPWATCH-1171): support custom cert in clair-scan #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
avi-biton
approved these changes
Aug 8, 2024
chmeliik
reviewed
Aug 12, 2024
task/clair-scan/0.1/clair-scan.yaml
Outdated
| - name: trusted-ca | ||
| mountPath: /etc/pki/tls/certs/ca-custom-bundle.crt | ||
| subPath: ca-bundle.crt | ||
| readOnly: true | ||
| - name: conftest-vulnerabilities |
There was a problem hiding this comment.
Is there a specific reason not to add the volume to the conftest-vulnerabilities step? If there isn't, it may be better to put the volumeMounts in the stepTemplate to make sure it applies to all steps
There was a problem hiding this comment.
I have no objections to add it that way. I'll give it a try.
yftacherzog
force-pushed
the
RHTAPWATCH-1171-clair-scan-custom-ca
branch
from
8c9a86f
to
e4b8c05
Compare
Support mounting a custom ca-bundle to allow the clair-scan task to use a registry with a self-signed certificate. Signed-off-by: Yftach Herzog <[email protected]>
yftacherzog
force-pushed
the
RHTAPWATCH-1171-clair-scan-custom-ca
branch
from
e4b8c05
to
a0d942c
Compare
mmorhun
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support mounting a custom ca-bundle to allow the clair-scan task to use a registry with a self-signed certificate.