add sast-shell-check task #1437
Open
+536
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft for now since we'll need to comply with some sast convention first. |
rhyw
force-pushed
the
sast-shellcheck
branch
2 times, most recently
from
0e75cb1
to
489ea23
Compare
rhyw
force-pushed
the
sast-shellcheck
branch
2 times, most recently
from
016a826
to
3819a60
Compare
kdudka
suggested changes
Sep 23, 2024
rhyw
force-pushed
the
sast-shellcheck
branch
from
3819a60
to
b6bdb3e
Compare
kdudka
reviewed
Sep 24, 2024
kdudka
suggested changes
Sep 24, 2024
rhyw
force-pushed
the
sast-shellcheck
branch
from
beabb08
to
cfaec5b
Compare
|
@kdudka I added 2 commits for review. I'll squash them into one single commit before it's getting merged. |
rhyw
force-pushed
the
sast-shellcheck
branch
from
cfaec5b
to
319a9aa
Compare
kdudka
reviewed
Sep 25, 2024
kdudka
suggested changes
Sep 25, 2024
rhyw
force-pushed
the
sast-shellcheck
branch
2 times, most recently
from
1c1285c
to
b7aa95f
Compare
kdudka
suggested changes
Sep 26, 2024
hanchuntao
reviewed
Sep 27, 2024
kdudka
reviewed
Sep 27, 2024
hanchuntao
reviewed
Sep 30, 2024
hanchuntao
reviewed
Sep 30, 2024
rhyw
force-pushed
the
sast-shellcheck
branch
from
ac33aad
to
9431a2f
Compare
dirgim
reviewed
Oct 22, 2024
|
PR rebased. Also renamed param "PROJECT_NVR" to "PROJECT_NAME" to be consistent with other sast tasks, as per suggestion from @jperezdealgaba . |
|
Let me know if a squash is needed. Thanks! |
|
/verify-owners |
|
Re-generated the oci-ta task / squashed the fix up commits. No other changes. |
|
/ok-to-test |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@dirgim The CI is green but the merge has failed. What should be the next steps? |
|
There are some infra-related issues with e2e tests and don't seem related to this change, rerunning should work as far as I can see. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.