-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLOUDDST-24366) Update description of show-sbom #1463
Conversation
f2a5b9d
to
38167a2
Compare
@rcerven @taylormadore could you please review this? |
38167a2
to
ffcc472
Compare
@arewm should there be mention about spdx, if we aren't even generating sbom in spdx ? |
The implementation isn't specific to either cyclonedx nor spdx. If we want to change this, I think we should actually remove the wording instead of adding more. Can SPDX even be attached or does it have to be an attestation? If the latter, then the current task definition won't be able to show the SPDX sbom. |
I thought we already produce sboms in attestations |
@midnightercz So will spdx sbom be attached like what's done for cyclonedx sbom in upload-sbom? Or buildah tasks will generate it as attestation? I think spdx is supported by cosign attach sbom:
|
So I checked and most of the tekton tasks use sbom attach --sbom-type=, where is cyclonedx or spdx based on task paramater |
SPDX format will be supported by build-definitions later. Update description of show-sbom tasks so that they are not limited to CycloneDX. Signed-off-by: Emily Zheng <[email protected]>
ffcc472
to
d4eab53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding my prior question
Can SPDX even be attached or does it have to be an attestation? If the latter, then the current task definition won't be able to show the SPDX sbom.
SPDX can be attached. The process using cosign attach
isn't specific to a particular SBOM type.
Merging without CI as this is just a change to the descriptions. |
SPDX format will be supported by build-definitions later. Update description of show-sbom tasks so that they are not limited to CycloneDX.