fix(KFLUXBUGS-1601): use base image annotation to get its tag #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Label org.opencontainers.image.base.name doesn't exist * Use annotation org.opencontainers.image.base.name to derive base image Signed-off-by: Hongwei Liu <[email protected]>
hongweiliu17
requested review from
dirgim,
14rcole,
Josh-Everett,
kasemAlem,
dheerajodha,
sonam1412,
jencull and
chipspeak
and removed request for
Josh-Everett and
sonam1412
hongweiliu17
force-pushed
the
KFLUXBUGS-1601
branch
from
83f6e8a
to
0dbf5d3
Compare
kasemAlem
approved these changes
Sep 26, 2024
sonam1412
reviewed
Sep 26, 2024
hongweiliu17
force-pushed
the
KFLUXBUGS-1601
branch
from
0dbf5d3
to
394d257
Compare
* quote string var to prevent word splitting SC2046 refer to https://github.com/konflux-ci/build-definitions/ actions/runs/11034165969/job/30647384452?pr=1468 Signed-off-by: Hongwei Liu <[email protected]>
hongweiliu17
force-pushed
the
KFLUXBUGS-1601
branch
from
394d257
to
0da6620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from slack
Signed-off-by: Hongwei Liu [email protected]
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.